Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the /proc filesystem on cygwin #7

Merged
merged 1 commit into from Feb 27, 2013
Merged

Use the /proc filesystem on cygwin #7

merged 1 commit into from Feb 27, 2013

Conversation

mithun
Copy link
Contributor

@mithun mithun commented Feb 15, 2013

Cygwin provides a working /proc filesystem that is pretty similar to
Linux distributions. P9Y::ProcessTable::Win32 is updated to recognize
when running on Cygwin and provide the following behavior:

  • Use the /proc filesystem to provide Cygwin process info
  • Use Win32::Process::Info to provide Windows process info

This provides the user with both Cygwin and Windows processes
when on cygwin and only Windows processes when on Win32.

@SineSwiper
Copy link
Owner

You have a bunch of space changes everywhere. Can you clean that up? (Three spaces, please, or vertical alignment when needed/desired.)

Also, I'm not sure about the win* properties in ::Process. The whole point of P9Y::PT is normalization of this stuff between OSs. What is the specific need for both pids?

@mithun
Copy link
Contributor Author

mithun commented Feb 16, 2013

You have a bunch of space changes everywhere. Can you clean that up? (Three spaces, please, or vertical alignment when needed/desired.)

I usually run code through perltidy. Of course, this is currently setup to my preference. If you have a perltidy config you'd like me to use please let me know. Otherwise I can go thru' and manually fix the indentation.

Also, I'm not sure about the win* properties in ::Process. The whole point of P9Y::PT is normalization of this stuff between OSs. What is the specific need for both pids?

When running under cygwin, both cygwin and Windows assign their own PIDs to the same process - perlcygwin. Under some conditions, users will need either the cygwin pid or windows pid or both. The win* properties are also exposed by Proc::PT under cygwin, so this will help users easily migrate to using P9Y::PT.

@mithun
Copy link
Contributor Author

mithun commented Feb 18, 2013

Fixed indentation to use 3 spaces.

@mithun
Use the /proc filesystem on cygwin
9b51815 
Cygwin provides a working /proc filesystem that is pretty similar to
Linux distributions. P9Y::ProcessTable::Win32 is updated to recognize
when running on Cygwin and provide the following behavior:

- Use the /proc filesystem to provide Cygwin process info
- Use Win32::Process::Info to provide Windows process info

This provides the user with both Cygwin and Windows processes
when on cygwin and only Windows processes when on Win32.
@SineSwiper
Copy link
Owner

Well, if P:PT already has it, then I'm cool with using it.

SineSwiper added a commit that referenced this pull request Feb 27, 2013
@SineSwiper
Merge pull request #7 from mithun/cygwin-use-proc
028a5d6 
Use the /proc filesystem on cygwin
@SineSwiper SineSwiper merged commit 028a5d6 into SineSwiper:master Feb 27, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mithun @SineSwiper